dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()
authorYunbo Yu <yuyunbo519@gmail.com>
Mon, 18 Apr 2022 14:20:21 +0000 (22:20 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Apr 2022 10:29:33 +0000 (15:59 +0530)
It is unnecessary to call spin_lock_bh() if you are already in a tasklet.

Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Link: https://lore.kernel.org/r/20220418142021.1241558-1-yuyunbo519@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/plx_dma.c

index 1ffcb5c..12725fa 100644 (file)
@@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
        struct plx_dma_desc *desc;
        u32 flags;
 
-       spin_lock_bh(&plxdev->ring_lock);
+       spin_lock(&plxdev->ring_lock);
 
        while (plxdev->tail != plxdev->head) {
                desc = plx_dma_get_desc(plxdev, plxdev->tail);
@@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
                plxdev->tail++;
        }
 
-       spin_unlock_bh(&plxdev->ring_lock);
+       spin_unlock(&plxdev->ring_lock);
 }
 
 static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)