drm/i915: Add planes affected by bigjoiner to the state
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 17 Nov 2020 19:47:11 +0000 (11:47 -0800)
committerManasi Navare <manasi.d.navare@intel.com>
Wed, 18 Nov 2020 19:41:42 +0000 (11:41 -0800)
Make sure both the bigjoiner "master" and "slave" plane are
in the state whenever either of them is in the state.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201117194718.11462-9-manasi.d.navare@intel.com
drivers/gpu/drm/i915/display/intel_display.c

index 0784495..78f89ec 100644 (file)
@@ -15108,6 +15108,44 @@ static bool active_planes_affects_min_cdclk(struct drm_i915_private *dev_priv)
                IS_IVYBRIDGE(dev_priv) || (INTEL_GEN(dev_priv) >= 11);
 }
 
+static int intel_crtc_add_bigjoiner_planes(struct intel_atomic_state *state,
+                                          struct intel_crtc *crtc,
+                                          struct intel_crtc *other)
+{
+       const struct intel_plane_state *plane_state;
+       struct intel_plane *plane;
+       u8 plane_ids = 0;
+       int i;
+
+       for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+               if (plane->pipe == crtc->pipe)
+                       plane_ids |= BIT(plane->id);
+       }
+
+       return intel_crtc_add_planes_to_state(state, other, plane_ids);
+}
+
+static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
+{
+       const struct intel_crtc_state *crtc_state;
+       struct intel_crtc *crtc;
+       int i;
+
+       for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
+               int ret;
+
+               if (!crtc_state->bigjoiner)
+                       continue;
+
+               ret = intel_crtc_add_bigjoiner_planes(state, crtc,
+                                                     crtc_state->bigjoiner_linked_crtc);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
        struct drm_i915_private *dev_priv = to_i915(state->base.dev);
@@ -15121,6 +15159,10 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
        if (ret)
                return ret;
 
+       ret = intel_bigjoiner_add_affected_planes(state);
+       if (ret)
+               return ret;
+
        for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
                ret = intel_plane_atomic_check(state, plane);
                if (ret) {