mtd: rawnand: atmel: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 14:25:31 +0000 (16:25 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 30 Sep 2020 14:44:16 +0000 (16:44 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200901142535.12819-2-krzk@kernel.org
drivers/mtd/nand/raw/atmel/nand-controller.c

index 8916a97cafa9c9de5c6d7984b0a8bc77d6ae20c0..309ce410d792b4f5d2942900790ab130d900d082 100644 (file)
@@ -2027,13 +2027,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
        platform_set_drvdata(pdev, nc);
 
        nc->pmecc = devm_atmel_pmecc_get(dev);
-       if (IS_ERR(nc->pmecc)) {
-               ret = PTR_ERR(nc->pmecc);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Could not get PMECC object (err = %d)\n",
-                               ret);
-               return ret;
-       }
+       if (IS_ERR(nc->pmecc))
+               return dev_err_probe(dev, PTR_ERR(nc->pmecc),
+                                    "Could not get PMECC object\n");
 
        if (nc->caps->has_dma && !atmel_nand_avoid_dma) {
                dma_cap_mask_t mask;