net/freescale: Don't set zero if FW not-available in dpaa
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 1 Mar 2020 14:44:54 +0000 (16:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Mar 2020 01:54:55 +0000 (17:54 -0800)
Rely on ethtool to properly present the fact that FW is not
available for the dpaa driver.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c

index 13ab669..6aa1fa2 100644 (file)
@@ -106,17 +106,8 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev,
 static void dpaa_get_drvinfo(struct net_device *net_dev,
                             struct ethtool_drvinfo *drvinfo)
 {
-       int len;
-
        strlcpy(drvinfo->driver, KBUILD_MODNAME,
                sizeof(drvinfo->driver));
-       len = snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
-                      "%X", 0);
-
-       if (len >= sizeof(drvinfo->fw_version)) {
-               /* Truncated output */
-               netdev_notice(net_dev, "snprintf() = %d\n", len);
-       }
        strlcpy(drvinfo->bus_info, dev_name(net_dev->dev.parent->parent),
                sizeof(drvinfo->bus_info));
 }