Remove V8_WARN_UNUSED_RESULT for simple getters.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23629031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16624 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/cpu.h b/src/cpu.h
index 58c7f5d..b2e9f7d 100644 (file)
--- a/src/cpu.h
+++ b/src/cpu.h
@@ -100,7 +100,7 @@ class CPU V8_FINAL BASE_EMBEDDED {
   bool has_vfp3_d32() const { return has_vfp3_d32_; }
 
   // Returns the number of processors online.
-  static int NumberOfProcessorsOnline() V8_WARN_UNUSED_RESULT;
+  static int NumberOfProcessorsOnline();
 
   // Initializes the cpu architecture support. Called once at VM startup.
   static void SetUp();

diff --git a/src/platform/condition-variable.h b/src/platform/condition-variable.h
index 43cc529..4d8a88a 100644 (file)
--- a/src/platform/condition-variable.h
+++ b/src/platform/condition-variable.h
@@ -105,10 +105,10 @@ class ConditionVariable V8_FINAL {
   };
 #endif
 
-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }
 

diff --git a/src/platform/elapsed-timer.h b/src/platform/elapsed-timer.h
index 773abbc..8044bd0 100644 (file)
--- a/src/platform/elapsed-timer.h
+++ b/src/platform/elapsed-timer.h
@@ -87,7 +87,7 @@ class ElapsedTimer V8_FINAL BASE_EMBEDDED {
 
   // Returns the time elapsed since the previous start. This method may only
   // be called on a previously started timer.
-  TimeDelta Elapsed() const V8_WARN_UNUSED_RESULT {
+  TimeDelta Elapsed() const {
     ASSERT(IsStarted());
     TimeDelta elapsed = Now() - start_ticks_;
     ASSERT(elapsed.InMicroseconds() >= 0);
@@ -97,13 +97,13 @@ class ElapsedTimer V8_FINAL BASE_EMBEDDED {
   // Returns |true| if the specified |time_delta| has elapsed since the
   // previous start, or |false| if not. This method may only be called on
   // a previously started timer.
-  bool HasExpired(TimeDelta time_delta) const V8_WARN_UNUSED_RESULT {
+  bool HasExpired(TimeDelta time_delta) const {
     ASSERT(IsStarted());
     return Elapsed() >= time_delta;
   }
 
  private:
-  V8_INLINE(static TimeTicks Now()) V8_WARN_UNUSED_RESULT {
+  V8_INLINE(static TimeTicks Now()) {
     TimeTicks now = TimeTicks::HighResNow();
     ASSERT(!now.IsNull());
     return now;

diff --git a/src/platform/mutex.h b/src/platform/mutex.h
index ff519b9..f08de4f 100644 (file)
--- a/src/platform/mutex.h
+++ b/src/platform/mutex.h
@@ -81,10 +81,10 @@ class Mutex V8_FINAL {
   typedef CRITICAL_SECTION NativeHandle;
 #endif
 
-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }
 
@@ -177,10 +177,10 @@ class RecursiveMutex V8_FINAL {
   // The implementation-defined native handle type.
   typedef Mutex::NativeHandle NativeHandle;
 
-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }
 

diff --git a/src/platform/semaphore.h b/src/platform/semaphore.h
index 221c7a3..2cfa142 100644 (file)
--- a/src/platform/semaphore.h
+++ b/src/platform/semaphore.h
@@ -80,10 +80,10 @@ class Semaphore V8_FINAL {
   typedef HANDLE NativeHandle;
 #endif
 
-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }
 

diff --git a/src/platform/socket.h b/src/platform/socket.h
index 6710692..e9e2fa2 100644 (file)
--- a/src/platform/socket.h
+++ b/src/platform/socket.h
@@ -66,11 +66,11 @@ class Socket V8_FINAL {
   // Set the value of the SO_REUSEADDR socket option.
   bool SetReuseAddress(bool reuse_address);
 
-  V8_INLINE(bool IsValid()) const V8_WARN_UNUSED_RESULT {
+  V8_INLINE(bool IsValid()) const {
     return native_handle_ != kInvalidNativeHandle;
   }
 
-  static int GetLastError() V8_WARN_UNUSED_RESULT;
+  static int GetLastError();
 
   // The implementation-defined native handle type.
 #if V8_OS_POSIX
@@ -81,10 +81,10 @@ class Socket V8_FINAL {
   static const NativeHandle kInvalidNativeHandle = INVALID_SOCKET;
 #endif
 
-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }