NFSD: Replace READ* macros that decode the fattr4 mode attribute
authorChuck Lever <chuck.lever@oracle.com>
Thu, 19 Nov 2020 18:54:26 +0000 (13:54 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:36 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index ac2f259..e6c3b67 100644 (file)
@@ -351,8 +351,11 @@ nfsd4_decode_fattr(struct nfsd4_compoundargs *argp, u32 *bmval,
        } else
                *acl = NULL;
        if (bmval[1] & FATTR4_WORD1_MODE) {
-               READ_BUF(4);
-               iattr->ia_mode = be32_to_cpup(p++);
+               u32 mode;
+
+               if (xdr_stream_decode_u32(argp->xdr, &mode) < 0)
+                       return nfserr_bad_xdr;
+               iattr->ia_mode = mode;
                iattr->ia_mode &= (S_IFMT | S_IALLUGO);
                iattr->ia_valid |= ATTR_MODE;
        }