clang/darwin: use response files with ld64
authorKeith Smiley <keithbsmiley@gmail.com>
Tue, 8 Jun 2021 23:40:30 +0000 (16:40 -0700)
committerKeith Smiley <keithbsmiley@gmail.com>
Wed, 9 Jun 2021 16:04:37 +0000 (09:04 -0700)
This crasher was fixed with Xcode 13.0 beta 1 / ld64 705. This is an
updated revert of https://reviews.llvm.org/D92357

Differential Revision: https://reviews.llvm.org/D103934

clang/lib/Driver/ToolChains/Darwin.cpp

index 5ccd230..8a0c472 100644 (file)
@@ -711,10 +711,7 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   }
 
   ResponseFileSupport ResponseSupport;
-  if (LinkerIsLLDDarwinNew) {
-    // Xcode12's ld64 added support for @response files, but it's crashy:
-    // https://openradar.appspot.com/radar?id=4933317065441280
-    // FIXME: Pass this for ld64 once it no longer crashes.
+  if (Version[0] >= 705 || LinkerIsLLDDarwinNew) {
     ResponseSupport = ResponseFileSupport::AtFileUTF8();
   } else {
     // For older versions of the linker, use the legacy filelist method instead.