media: si470x-i2c: Add optional reset-gpio support
authorPawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>
Fri, 7 Dec 2018 13:58:11 +0000 (11:58 -0200)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 21 Jan 2019 17:36:18 +0000 (15:36 -0200)
If reset-gpio is defined, use it to bring device out of reset.
Without this, it's not possible to access si470x registers.

Signed-off-by: Pawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/radio/si470x/radio-si470x-i2c.c
drivers/media/radio/si470x/radio-si470x.h

index a7ac09c..15eea2b 100644 (file)
@@ -28,6 +28,7 @@
 #include <linux/i2c.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
 
 #include "radio-si470x.h"
@@ -392,6 +393,17 @@ static int si470x_i2c_probe(struct i2c_client *client,
        radio->videodev.release = video_device_release_empty;
        video_set_drvdata(&radio->videodev, radio);
 
+       radio->gpio_reset = devm_gpiod_get_optional(&client->dev, "reset",
+                                                   GPIOD_OUT_LOW);
+       if (IS_ERR(radio->gpio_reset)) {
+               retval = PTR_ERR(radio->gpio_reset);
+               dev_err(&client->dev, "Failed to request gpio: %d\n", retval);
+               goto err_all;
+       }
+
+       if (radio->gpio_reset)
+               gpiod_set_value(radio->gpio_reset, 1);
+
        /* power up : need 110ms */
        radio->registers[POWERCFG] = POWERCFG_ENABLE;
        if (si470x_set_register(radio, POWERCFG) < 0) {
@@ -478,6 +490,9 @@ static int si470x_i2c_remove(struct i2c_client *client)
 
        video_unregister_device(&radio->videodev);
 
+       if (radio->gpio_reset)
+               gpiod_set_value(radio->gpio_reset, 0);
+
        return 0;
 }
 
index 35fa0f3..6fd6a39 100644 (file)
@@ -189,6 +189,7 @@ struct si470x_device {
 
 #if IS_ENABLED(CONFIG_I2C_SI470X)
        struct i2c_client *client;
+       struct gpio_desc *gpio_reset;
 #endif
 };