scsi: smartpqi: remove set but not used variable 'ctrl_info'
authorYueHaibing <yuehaibing@huawei.com>
Sat, 31 Aug 2019 13:03:48 +0000 (13:03 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Oct 2019 02:37:18 +0000 (22:37 -0400)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_driver_version_show':
drivers/scsi/smartpqi/smartpqi_init.c:6164:24: warning:
 variable 'ctrl_info' set but not used [-Wunused-but-set-variable]

commit 6d90615f1346 ("scsi: smartpqi: add sysfs entries") added it but
it was never used. Also remove variable 'shost'.

[mkp: commit desc]

Link: https://lore.kernel.org/r/20190831130348.20552-1-yuehaibing@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/smartpqi/smartpqi_init.c

index 652d482..4f649ad 100644 (file)
@@ -6157,12 +6157,6 @@ static ssize_t pqi_firmware_version_show(struct device *dev,
 static ssize_t pqi_driver_version_show(struct device *dev,
        struct device_attribute *attr, char *buffer)
 {
-       struct Scsi_Host *shost;
-       struct pqi_ctrl_info *ctrl_info;
-
-       shost = class_to_shost(dev);
-       ctrl_info = shost_to_hba(shost);
-
        return snprintf(buffer, PAGE_SIZE,
                "%s\n", DRIVER_VERSION BUILD_TIMESTAMP);
 }