myri10ge: remove redundant assignment to variable status
authorColin Ian King <colin.i.king@gmail.com>
Mon, 18 Apr 2022 14:37:59 +0000 (15:37 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Apr 2022 09:23:24 +0000 (10:23 +0100)
Variable status is being assigned a value that is never read, it is
being re-assigned again later on. The assignment is redundant and can
be removed.

Cleans up clang scan build warning:
drivers/net/ethernet/myricom/myri10ge/myri10ge.c:582:7: warning: Although
the value stored to 'status' is used in the enclosing expression, the
value is never actually read from 'status' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c

index 21d2645..fe5e773 100644 (file)
@@ -579,7 +579,7 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)
        int status;
        unsigned i;
 
-       if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
+       if (request_firmware(&fw, mgp->fw_name, dev) < 0) {
                dev_err(dev, "Unable to load %s firmware image via hotplug\n",
                        mgp->fw_name);
                status = -EINVAL;