batman-adv: Use default throughput value on cfg80211 error
authorSven Eckelmann <sven@narfation.org>
Mon, 16 Mar 2020 22:30:46 +0000 (23:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2020 08:07:51 +0000 (09:07 +0100)
commit 3f3f87325dcb3c201076c81490f4da91ad4c09fc upstream.

A wifi interface should never be handled like an ethernet devices. The
parser of the cfg80211 output must therefore skip the ethtool code when
cfg80211_get_station returned an error.

Fixes: f44a3ae9a281 ("batman-adv: refactor wifi interface detection")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Reviewed-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/bat_v_elp.c

index 5d79004..337cdcd 100644 (file)
@@ -100,8 +100,10 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh)
                                 */
                                return 0;
                        }
-                       if (!ret)
-                               return sinfo.expected_throughput / 100;
+                       if (ret)
+                               goto default_throughput;
+
+                       return sinfo.expected_throughput / 100;
                }
 
                /* unsupported WiFi driver version */