media: i2c: imx258: Issue reset before starting streaming
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 31 Mar 2022 16:12:12 +0000 (17:12 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:33:33 +0000 (11:33 +0000)
Whilst not documented, register 0x0103 bit 0 is the soft
reset for the sensor, so send it before trying to configure
the sensor.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/media/i2c/imx258.c

index 416f1b7..4759a30 100644 (file)
@@ -20,6 +20,8 @@
 #define IMX258_MODE_STANDBY            0x00
 #define IMX258_MODE_STREAMING          0x01
 
+#define IMX258_REG_RESET               0x0103
+
 /* Chip ID */
 #define IMX258_REG_CHIP_ID             0x0016
 #define IMX258_CHIP_ID                 0x0258
@@ -1279,6 +1281,14 @@ static int imx258_start_streaming(struct imx258 *imx258)
        const struct imx258_link_freq_config *link_freq_cfg;
        int ret, link_freq_index;
 
+       ret = imx258_write_reg(imx258, IMX258_REG_RESET, IMX258_REG_VALUE_08BIT,
+                              0x01);
+       if (ret) {
+               dev_err(&client->dev, "%s failed to reset sensor\n", __func__);
+               return ret;
+       }
+       usleep_range(10000, 15000);
+
        /* Setup PLL */
        link_freq_index = imx258->cur_mode->link_freq_index;
        link_freq_cfg = &imx258->link_freq_configs[link_freq_index];