dmaengine: xilinx: dpdma: remove comparison of unsigned expression
authorVinod Koul <vkoul@kernel.org>
Sat, 18 Jul 2020 13:51:59 +0000 (19:21 +0530)
committerVinod Koul <vkoul@kernel.org>
Wed, 22 Jul 2020 16:30:19 +0000 (22:00 +0530)
xilinx_dpdma_config() channel id is unsigned int and compares with
ZYNQMP_DPDMA_VIDEO0 which is zero, so remove this comparison

drivers/dma/xilinx/xilinx_dpdma.c:1073:15: warning: comparison of
unsigned expression in ‘>= 0’ is always true [-Wtype-limits] if
(chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)

Link: https://lore.kernel.org/r/20200718135201.191881-1-vkoul@kernel.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/xilinx_dpdma.c

index af88a67..8e60237 100644 (file)
@@ -1070,7 +1070,7 @@ static int xilinx_dpdma_config(struct dma_chan *dchan,
         * Abuse the slave_id to indicate that the channel is part of a video
         * group.
         */
-       if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
+       if (chan->id <= ZYNQMP_DPDMA_VIDEO2)
                chan->video_group = config->slave_id != 0;
 
        spin_unlock_irqrestore(&chan->lock, flags);