dm: prefer '"%s...", __func__'

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 9249c75dd0bb18bb5567fa882938bfe491f8fa9e..acffed750e3edc8d248a409626e49ba57172e5c6 100644 (file)
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -203,15 +203,15 @@ static int sb_check(struct dm_block_validator *v,
        __le32 csum_le;
 
        if (dm_block_location(b) != le64_to_cpu(disk_super->blocknr)) {
-               DMERR("sb_check failed: blocknr %llu: wanted %llu",
-                     le64_to_cpu(disk_super->blocknr),
+               DMERR("%s failed: blocknr %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk_super->blocknr),
                      (unsigned long long)dm_block_location(b));
                return -ENOTBLK;
        }
 
        if (le64_to_cpu(disk_super->magic) != CACHE_SUPERBLOCK_MAGIC) {
-               DMERR("sb_check failed: magic %llu: wanted %llu",
-                     le64_to_cpu(disk_super->magic),
+               DMERR("%s failed: magic %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk_super->magic),
                      (unsigned long long)CACHE_SUPERBLOCK_MAGIC);
                return -EILSEQ;
        }
@@ -220,8 +220,8 @@ static int sb_check(struct dm_block_validator *v,
                                             sb_block_size - sizeof(__le32),
                                             SUPERBLOCK_CSUM_XOR));
        if (csum_le != disk_super->csum) {
-               DMERR("sb_check failed: csum %u: wanted %u",
-                     le32_to_cpu(csum_le), le32_to_cpu(disk_super->csum));
+               DMERR("%s failed: csum %u: wanted %u",
+                     __func__, le32_to_cpu(csum_le), le32_to_cpu(disk_super->csum));
                return -EILSEQ;
        }
 

diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index f8f7994f4f27c78029b3c63fc9ce6731caecfd68..c2e7780cdd2ddece6b476743a2810c1a868afbe8 100644 (file)
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -229,15 +229,15 @@ static int sb_check(struct dm_block_validator *v,
        __le32 csum_le;
 
        if (dm_block_location(b) != le64_to_cpu(disk->blocknr)) {
-               DMERR("sb_check failed: blocknr %llu: wanted %llu",
-                     le64_to_cpu(disk->blocknr),
+               DMERR("%s failed: blocknr %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk->blocknr),
                      (unsigned long long)dm_block_location(b));
                return -ENOTBLK;
        }
 
        if (le64_to_cpu(disk->magic) != SUPERBLOCK_MAGIC) {
-               DMERR("sb_check failed: magic %llu: wanted %llu",
-                     le64_to_cpu(disk->magic),
+               DMERR("%s failed: magic %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk->magic),
                      (unsigned long long) SUPERBLOCK_MAGIC);
                return -EILSEQ;
        }
@@ -246,8 +246,8 @@ static int sb_check(struct dm_block_validator *v,
                                             sb_block_size - sizeof(__le32),
                                             SUPERBLOCK_CSUM_XOR));
        if (csum_le != disk->csum) {
-               DMERR("sb_check failed: csum %u: wanted %u",
-                     le32_to_cpu(csum_le), le32_to_cpu(disk->csum));
+               DMERR("%s failed: csum %u: wanted %u",
+                     __func__, le32_to_cpu(csum_le), le32_to_cpu(disk->csum));
                return -EILSEQ;
        }
 

diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index 1f97d6612648c90b935d08051328dcca7727a15e..8e3d31a7fe9ff31bd8922bcabc34fef14609f42a 100644 (file)
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -3093,7 +3093,7 @@ clear_journal:
 
 static void dm_integrity_enter_synchronous_mode(struct dm_integrity_c *ic)
 {
-       DEBUG_print("dm_integrity_enter_synchronous_mode\n");
+       DEBUG_print("%s\n", __func__);
 
        if (ic->mode == 'B') {
                ic->bitmap_flush_interval = msecs_to_jiffies(10) + 1;
@@ -3109,7 +3109,7 @@ static int dm_integrity_reboot(struct notifier_block *n, unsigned long code, voi
 {
        struct dm_integrity_c *ic = container_of(n, struct dm_integrity_c, reboot_notifier);
 
-       DEBUG_print("dm_integrity_reboot\n");
+       DEBUG_print("%s\n", __func__);
 
        dm_integrity_enter_synchronous_mode(ic);
 

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 25cebf43537071d61c55b00c831cc72943057d2e..7a90dadc20f643b8529d9b4002cbb76ed9893304 100644 (file)
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1409,7 +1409,7 @@ static int populate_table(struct dm_table *table,
        char *target_params;
 
        if (!param->target_count) {
-               DMERR("populate_table: no targets specified");
+               DMERR("%s: no targets specified", __func__);
                return -EINVAL;
        }
 

diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 9ef8dcd35fe97dfa950fd3148971c9d365a4521c..b27d63c0897c724916ed4d4e87aceb8981d3fce2 100644 (file)
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -739,15 +739,15 @@ static void process_queued_bios(struct work_struct *work)
 /*
  * If we run out of usable paths, should we queue I/O or error it?
  */
-static int queue_if_no_path(struct multipath *m, bool queue_if_no_path,
+static int queue_if_no_path(struct multipath *m, bool f_queue_if_no_path,
                            bool save_old_value, const char *caller)
 {
        unsigned long flags;
        bool queue_if_no_path_bit, saved_queue_if_no_path_bit;
        const char *dm_dev_name = dm_table_device_name(m->ti->table);
 
-       DMDEBUG("%s: %s caller=%s queue_if_no_path=%d save_old_value=%d",
-               dm_dev_name, __func__, caller, queue_if_no_path, save_old_value);
+       DMDEBUG("%s: %s caller=%s f_queue_if_no_path=%d save_old_value=%d",
+               dm_dev_name, __func__, caller, f_queue_if_no_path, save_old_value);
 
        spin_lock_irqsave(&m->lock, flags);
 
@@ -760,11 +760,11 @@ static int queue_if_no_path(struct multipath *m, bool queue_if_no_path,
                              dm_dev_name);
                } else
                        assign_bit(MPATHF_SAVED_QUEUE_IF_NO_PATH, &m->flags, queue_if_no_path_bit);
-       } else if (!queue_if_no_path && saved_queue_if_no_path_bit) {
+       } else if (!f_queue_if_no_path && saved_queue_if_no_path_bit) {
                /* due to "fail_if_no_path" message, need to honor it. */
                clear_bit(MPATHF_SAVED_QUEUE_IF_NO_PATH, &m->flags);
        }
-       assign_bit(MPATHF_QUEUE_IF_NO_PATH, &m->flags, queue_if_no_path);
+       assign_bit(MPATHF_QUEUE_IF_NO_PATH, &m->flags, f_queue_if_no_path);
 
        DMDEBUG("%s: after %s changes; QIFNP = %d; SQIFNP = %d; DNFS = %d",
                dm_dev_name, __func__,
@@ -774,7 +774,7 @@ static int queue_if_no_path(struct multipath *m, bool queue_if_no_path,
 
        spin_unlock_irqrestore(&m->lock, flags);
 
-       if (!queue_if_no_path) {
+       if (!f_queue_if_no_path) {
                dm_table_run_md_queue_async(m->ti->table);
                process_queued_io_list(m);
        }
@@ -1468,7 +1468,7 @@ static int switch_pg_num(struct multipath *m, const char *pgstr)
 
        if (!pgstr || (sscanf(pgstr, "%u%c", &pgnum, &dummy) != 1) || !pgnum ||
            !m->nr_priority_groups || (pgnum > m->nr_priority_groups)) {
-               DMWARN("invalid PG number supplied to switch_pg_num");
+               DMWARN("invalid PG number supplied to %s", __func__);
                return -EINVAL;
        }
 

diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c
index 85427e96e8cba202a367efa7a71e1f43677073f5..2b12e0e2c87915a85b7427d27958f1834a53d379 100644 (file)
--- a/drivers/md/dm-thin-metadata.c
+++ b/drivers/md/dm-thin-metadata.c
@@ -269,15 +269,15 @@ static int sb_check(struct dm_block_validator *v,
        __le32 csum_le;
 
        if (dm_block_location(b) != le64_to_cpu(disk_super->blocknr)) {
-               DMERR("sb_check failed: blocknr %llu: wanted %llu",
-                     le64_to_cpu(disk_super->blocknr),
+               DMERR("%s failed: blocknr %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk_super->blocknr),
                      (unsigned long long)dm_block_location(b));
                return -ENOTBLK;
        }
 
        if (le64_to_cpu(disk_super->magic) != THIN_SUPERBLOCK_MAGIC) {
-               DMERR("sb_check failed: magic %llu: wanted %llu",
-                     le64_to_cpu(disk_super->magic),
+               DMERR("%s failed: magic %llu: wanted %llu",
+                     __func__, le64_to_cpu(disk_super->magic),
                      (unsigned long long)THIN_SUPERBLOCK_MAGIC);
                return -EILSEQ;
        }
@@ -286,8 +286,8 @@ static int sb_check(struct dm_block_validator *v,
                                             block_size - sizeof(__le32),
                                             SUPERBLOCK_CSUM_XOR));
        if (csum_le != disk_super->csum) {
-               DMERR("sb_check failed: csum %u: wanted %u",
-                     le32_to_cpu(csum_le), le32_to_cpu(disk_super->csum));
+               DMERR("%s failed: csum %u: wanted %u",
+                     __func__, le32_to_cpu(csum_le), le32_to_cpu(disk_super->csum));
                return -EILSEQ;
        }
 

diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index f4955c4dbe47cfecf9389b305886b4560dc3549b..1db64a24623d61ef9a662d6927f1c8388c7a2958 100644 (file)
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -165,7 +165,7 @@ static int verity_hash_final(struct dm_verity *v, struct ahash_request *req,
                r = verity_hash_update(v, req, v->salt, v->salt_size, wait);
 
                if (r < 0) {
-                       DMERR("verity_hash_final failed updating salt: %d", r);
+                       DMERR("%s failed updating salt: %d", __func__, r);
                        goto out;
                }
        }
@@ -423,7 +423,7 @@ static int verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io,
                r = crypto_wait_req(crypto_ahash_update(req), wait);
 
                if (unlikely(r < 0)) {
-                       DMERR("verity_for_io_block crypto op failed: %d", r);
+                       DMERR("%s crypto op failed: %d", __func__, r);
                        return r;
                }
 

diff --git a/drivers/md/persistent-data/dm-array.c b/drivers/md/persistent-data/dm-array.c
index 81d66fc08d49ea18f2c38d446378043c0739be7f..10dd058c56c02cb366987132c844d7f5cb2c45b6 100644 (file)
--- a/drivers/md/persistent-data/dm-array.c
+++ b/drivers/md/persistent-data/dm-array.c
@@ -58,7 +58,7 @@ static int array_block_check(struct dm_block_validator *v,
        __le32 csum_disk;
 
        if (dm_block_location(b) != le64_to_cpu(bh_le->blocknr)) {
-               DMERR_LIMIT("array_block_check failed: blocknr %llu != wanted %llu",
+               DMERR_LIMIT("%s failed: blocknr %llu != wanted %llu", __func__,
                            (unsigned long long) le64_to_cpu(bh_le->blocknr),
                            (unsigned long long) dm_block_location(b));
                return -ENOTBLK;
@@ -68,7 +68,7 @@ static int array_block_check(struct dm_block_validator *v,
                                               size_of_block - sizeof(__le32),
                                               CSUM_XOR));
        if (csum_disk != bh_le->csum) {
-               DMERR_LIMIT("array_block_check failed: csum %u != wanted %u",
+               DMERR_LIMIT("%s failed: csum %u != wanted %u", __func__,
                            (unsigned int) le32_to_cpu(csum_disk),
                            (unsigned int) le32_to_cpu(bh_le->csum));
                return -EILSEQ;

diff --git a/drivers/md/persistent-data/dm-btree-spine.c b/drivers/md/persistent-data/dm-btree-spine.c
index 27f379c138093c9528f792621e2a311b0efaca41..7540383b7cf3e940baf8b5fee6f755bde0606516 100644 (file)
--- a/drivers/md/persistent-data/dm-btree-spine.c
+++ b/drivers/md/persistent-data/dm-btree-spine.c
@@ -40,7 +40,7 @@ static int node_check(struct dm_block_validator *v,
        uint32_t flags, nr_entries, max_entries;
 
        if (dm_block_location(b) != le64_to_cpu(h->blocknr)) {
-               DMERR_LIMIT("node_check failed: blocknr %llu != wanted %llu",
+               DMERR_LIMIT("%s failed: blocknr %llu != wanted %llu", __func__,
                            le64_to_cpu(h->blocknr), dm_block_location(b));
                return -ENOTBLK;
        }
@@ -49,7 +49,7 @@ static int node_check(struct dm_block_validator *v,
                                               block_size - sizeof(__le32),
                                               BTREE_CSUM_XOR));
        if (csum_disk != h->csum) {
-               DMERR_LIMIT("node_check failed: csum %u != wanted %u",
+               DMERR_LIMIT("%s failed: csum %u != wanted %u", __func__,
                            le32_to_cpu(csum_disk), le32_to_cpu(h->csum));
                return -EILSEQ;
        }
@@ -60,12 +60,12 @@ static int node_check(struct dm_block_validator *v,
 
        if (sizeof(struct node_header) +
            (sizeof(__le64) + value_size) * max_entries > block_size) {
-               DMERR_LIMIT("node_check failed: max_entries too large");
+               DMERR_LIMIT("%s failed: max_entries too large", __func__);
                return -EILSEQ;
        }
 
        if (nr_entries > max_entries) {
-               DMERR_LIMIT("node_check failed: too many entries");
+               DMERR_LIMIT("%s failed: too many entries", __func__);
                return -EILSEQ;
        }
 
@@ -74,7 +74,7 @@ static int node_check(struct dm_block_validator *v,
         */
        flags = le32_to_cpu(h->flags);
        if (!(flags & INTERNAL_NODE) && !(flags & LEAF_NODE)) {
-               DMERR_LIMIT("node_check failed: node is neither INTERNAL or LEAF");
+               DMERR_LIMIT("%s failed: node is neither INTERNAL or LEAF", __func__);
                return -EILSEQ;
        }
 

diff --git a/drivers/md/persistent-data/dm-space-map-common.c b/drivers/md/persistent-data/dm-space-map-common.c
index fd4cea718e68037c9c0615b260b9044def490669..e927ed85321560e9d13c09936bf339479a99801e 100644 (file)
--- a/drivers/md/persistent-data/dm-space-map-common.c
+++ b/drivers/md/persistent-data/dm-space-map-common.c
@@ -42,7 +42,7 @@ static int index_check(struct dm_block_validator *v,
        __le32 csum_disk;
 
        if (dm_block_location(b) != le64_to_cpu(mi_le->blocknr)) {
-               DMERR_LIMIT("index_check failed: blocknr %llu != wanted %llu",
+               DMERR_LIMIT("%s failed: blocknr %llu != wanted %llu", __func__,
                            le64_to_cpu(mi_le->blocknr), dm_block_location(b));
                return -ENOTBLK;
        }
@@ -51,7 +51,7 @@ static int index_check(struct dm_block_validator *v,
                                               block_size - sizeof(__le32),
                                               INDEX_CSUM_XOR));
        if (csum_disk != mi_le->csum) {
-               DMERR_LIMIT("index_check failed: csum %u != wanted %u",
+               DMERR_LIMIT("i%s failed: csum %u != wanted %u", __func__,
                            le32_to_cpu(csum_disk), le32_to_cpu(mi_le->csum));
                return -EILSEQ;
        }