drm/amdgpu: fix uninitialized variable pasid_mapping_needed
authorColin Ian King <colin.king@canonical.com>
Thu, 3 Oct 2019 21:52:27 +0000 (22:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:46:00 +0000 (16:46 +0100)
[ Upstream commit 17cf678a33c6196a3df4531fe5aec91384c9eeb5 ]

The boolean variable pasid_mapping_needed is not initialized and
there are code paths that do not assign it any value before it is
is read later.  Fix this by initializing pasid_mapping_needed to
false.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index 7700c32..c7514f7 100644 (file)
@@ -1035,7 +1035,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, bool need_
                id->oa_size != job->oa_size);
        bool vm_flush_needed = job->vm_needs_flush;
        struct dma_fence *fence = NULL;
-       bool pasid_mapping_needed;
+       bool pasid_mapping_needed = false;
        unsigned patch_offset = 0;
        int r;