ps3vram: remove bio splitting
authorChristoph Hellwig <hch@lst.de>
Mon, 23 Jan 2023 07:47:18 +0000 (08:47 +0100)
committerJens Axboe <axboe@kernel.dk>
Sun, 29 Jan 2023 22:18:35 +0000 (15:18 -0700)
ps3vram iterates over the bio one segment, that is page aligned and max
page sized chunk, a time.  Because of that there is no point in
calling bio_split_to_limits, or explicitly setting the default limits
that are only used by bio_split_to_limits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Geoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20230123074718.57951-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ps3vram.c

index 574e470..38d42af 100644 (file)
@@ -586,10 +586,6 @@ static void ps3vram_submit_bio(struct bio *bio)
 
        dev_dbg(&dev->core, "%s\n", __func__);
 
-       bio = bio_split_to_limits(bio);
-       if (!bio)
-               return;
-
        spin_lock_irq(&priv->lock);
        busy = !bio_list_empty(&priv->list);
        bio_list_add(&priv->list, bio);
@@ -749,9 +745,6 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev)
        gendisk->private_data = dev;
        strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name));
        set_capacity(gendisk, priv->size >> 9);
-       blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS);
-       blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE);
-       blk_queue_max_hw_sectors(gendisk->queue, BLK_SAFE_MAX_SECTORS);
 
        dev_info(&dev->core, "%s: Using %llu MiB of GPU memory\n",
                 gendisk->disk_name, get_capacity(gendisk) >> 11);