projects / profile / ivi / webkit-efl.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 5bec5a7)
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how...
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Oct 2011 22:56:41 +0000 (22:56 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Oct 2011 22:56:41 +0000 (22:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=69374

Unreviewed.

Per https://bugs.webkit.org/show_bug.cgi?id=69374#c7
updating the chunksize to be a bit smaller now that the total
size of the html5 spec is smaller than when I wrote the test.

This should increase the prevalence of style resolution in the
sample time, which more closely matches instrument samples
taken when loading the full page in Safari.

* Parser/html5-full-render.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog patch | blob | history
PerformanceTests/Parser/html5-full-render.html patch | blob | history

diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog
index 384e225..9c51196 100644 (file)
--- a/PerformanceTests/ChangeLog
+++ b/PerformanceTests/ChangeLog
@@ -3,6 +3,23 @@
         Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
         https://bugs.webkit.org/show_bug.cgi?id=69374
 
+        Unreviewed.
+
+        Per https://bugs.webkit.org/show_bug.cgi?id=69374#c7
+        updating the chunksize to be a bit smaller now that the total
+        size of the html5 spec is smaller than when I wrote the test.
+
+        This should increase the prevalence of style resolution in the
+        sample time, which more closely matches instrument samples
+        taken when loading the full page in Safari.
+
+        * Parser/html5-full-render.html:
+
+2011-10-04  Eric Seidel  <eric@webkit.org>
+
+        Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
+        https://bugs.webkit.org/show_bug.cgi?id=69374
+
         Reviewed by James Robinson.
 
         This should finally be able to provide us with a repeatable metric
diff --git a/PerformanceTests/Parser/html5-full-render.html b/PerformanceTests/Parser/html5-full-render.html
index 446a14d..1b5a3c3 100644 (file)
--- a/PerformanceTests/Parser/html5-full-render.html
+++ b/PerformanceTests/Parser/html5-full-render.html
@@ -11,7 +11,7 @@ var chunks = [];
 // Larger chunk sizes will show more samples in line layout.
 // Smaller chunk sizes run slower overall, as the per-chunk overhead is high.
 // Testing on my machine has shown that we need 10-15 chunks before style resolution is always the top sample.
-var chunkSize = 750000; // 8mb / 750k = approx 12 chunks.
+var chunkSize = 500000; // 6.09mb / 500k = approx 13 chunks (thus 13 forced layouts/style resolves).
 var chunkCount = Math.ceil(spec.length / chunkSize);
 for (var chunkIndex = 0; chunkIndex < chunkCount; chunkIndex++) {
     var chunk = spec.substring(chunkIndex * chunkSize, chunkSize);
@@ -36,7 +36,7 @@ function loadChunkedSpecIntoIframe(iframe) {
         // Note that we won't cause a style resolve until we've encountered the <body> element.
         // Thus the number of chunks counted above is not exactly equal to the number of style resolves.
         if (iframe.contentDocument.body)
-            iframe.contentDocument.body.clientHeight; // Force a full style-resolve.
+            iframe.contentDocument.body.clientHeight; // Force a full layout/style-resolve.
     }
 
     iframe.contentDocument.close();
Domain: Web Framework / Uncategorized;