libinput: do not switch output associations on disable
authorPekka Paalanen <pekka.paalanen@collabora.co.uk>
Tue, 20 Mar 2018 12:45:36 +0000 (14:45 +0200)
committerPekka Paalanen <pekka.paalanen@collabora.co.uk>
Fri, 20 Apr 2018 12:27:54 +0000 (15:27 +0300)
If an input device is associated to an output that then gets disabled,
there is no case where associating to a different output would be
correct.

The output association is used for absolute positioned input devices,
and an input device like a touchscreen cannot ever be automatically
valid for more than one possible output - the touchscreen display
device.

Therefore do not automatically reassing implicitly associated input
devices to another output. This removes some log spam on shutdown.

In fact, if there can be more than one output at any time, absolute
input devices must be explicitly configured to associate with the
correct output, or the results are essentially undefined in any case.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
libweston/libinput-device.c

index dbbaae3..e173861 100644 (file)
@@ -434,16 +434,8 @@ notify_output_destroy(struct wl_listener *listener, void *data)
        struct evdev_device *device =
                container_of(listener,
                             struct evdev_device, output_destroy_listener);
-       struct weston_compositor *c = device->seat->compositor;
-       struct weston_output *output;
-
-       if (!device->output_name && !wl_list_empty(&c->output_list)) {
-               output = container_of(c->output_list.next,
-                                     struct weston_output, link);
-               evdev_device_set_output(device, output);
-       } else {
-               evdev_device_set_output(device, NULL);
-       }
+
+       evdev_device_set_output(device, NULL);
 }
 
 /**