regulator: rk808: fix asynchronous probing
authorSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 4 May 2023 17:36:15 +0000 (19:36 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 23 May 2023 18:01:56 +0000 (19:01 +0100)
If the probe routine fails with -EPROBE_DEFER after taking over the
OF node from its parent driver, reprobing triggers pinctrl_bind_pins()
and that will fail. Fix this by setting of_node_reused, so that the
device does not try to setup pin muxing.

For me this always happens once the driver is marked to prefer async
probing and never happens without that flag.

Fixes: 259b93b21a9f ("regulator: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in 4.14")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20230504173618.142075-12-sebastian.reichel@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/rk808-regulator.c

index 3637e81..80ba782 100644 (file)
@@ -1336,6 +1336,7 @@ static int rk808_regulator_probe(struct platform_device *pdev)
 
        config.dev = &pdev->dev;
        config.dev->of_node = pdev->dev.parent->of_node;
+       config.dev->of_node_reused = true;
        config.driver_data = pdata;
        config.regmap = regmap;