media: atomisp: Remove isp->need_gfx_throttle field

Remove the isp->need_gfx_throttle field it is only ever set and
never read.

Also the code setting it is broken, comparing run_mode->val to
ATOMISP_SUBDEV_PAD_SOURCE_VIDEO which are not of the same type /
not part of the same enum.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index bb49d6f..ed1a534 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4693,16 +4693,6 @@ int atomisp_set_fmt(struct video_device *vdev, struct v4l2_format *f)
        f->fmt.pix = pipe->pix;
        f->fmt.pix.priv = PAGE_ALIGN(pipe->pix.width *
                                     pipe->pix.height * 2);
-
-       /*
-        * If in video 480P case, no GFX throttle
-        */
-       if (asd->run_mode->val == ATOMISP_SUBDEV_PAD_SOURCE_VIDEO &&
-           f->fmt.pix.width == 720 && f->fmt.pix.height == 480)
-               isp->need_gfx_throttle = false;
-       else
-               isp->need_gfx_throttle = true;
-
        /* Report the needed sizes */
        f->fmt.pix.sizeimage = pipe->pix.sizeimage;
        f->fmt.pix.bytesperline = pipe->pix.bytesperline;

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index fa362c8..a95c41d 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -539,7 +539,6 @@ static void atomisp_dev_init_struct(struct atomisp_device *isp)
 {
        unsigned int i;
 
-       isp->need_gfx_throttle = true;
        isp->isp_fatal_error = false;
        isp->mipi_frame_size = 0;
 

diff --git a/drivers/staging/media/atomisp/pci/atomisp_internal.h b/drivers/staging/media/atomisp/pci/atomisp_internal.h
index 1fac99f..e531f0c 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_internal.h
+++ b/drivers/staging/media/atomisp/pci/atomisp_internal.h
@@ -211,8 +211,6 @@ struct atomisp_device {
 
        spinlock_t lock; /* Protects asd.streaming */
 
-       bool need_gfx_throttle;
-
        unsigned int mipi_frame_size;
        const struct atomisp_dfs_config *dfs;
        unsigned int hpll_freq;