projects
/
platform
/
upstream
/
enlightenment.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a019ffb
)
fix possible memleak when creating new app menu entries
author
Mike Blumenkrantz
<m.blumenkran@samsung.com>
Mon, 20 May 2013 09:25:49 +0000
(10:25 +0100)
committer
Mike Blumenkrantz
<m.blumenkran@samsung.com>
Mon, 20 May 2013 10:16:07 +0000
(11:16 +0100)
klocwork issue
src/bin/e_int_menus.c
patch
|
blob
|
history
diff --git
a/src/bin/e_int_menus.c
b/src/bin/e_int_menus.c
index 0d916ca03f6ac3bfe39c73361b6bee94fd5dd858..6a3badd6dc202de90db56fed8ffd09dbbe56b37b 100644
(file)
--- a/
src/bin/e_int_menus.c
+++ b/
src/bin/e_int_menus.c
@@
-723,7
+723,13
@@
_e_int_menus_app_config_append(Efreet_Desktop *desktop)
EINA_LIST_FOREACH_SAFE(e_config->menu_applications, l, l_next, ma)
{
if ((!strcmp(ma->orig_path, cma->orig_path)) && (ma->load_time == cma->load_time))
- return ma->exec_valid;
+ {
+ eina_stringshare_del(cma->orig_path);
+ eina_stringshare_del(cma->try_exec);
+ eina_stringshare_del(cma->exec);
+ free(cma);
+ return ma->exec_valid;
+ }
if ((!strcmp(ma->orig_path, cma->orig_path)) && (ma->load_time != cma->load_time))
{