staging: rtl8723bs: rtw_cmd: Compress lines for immediate return
authorSimran Singhal <singhalsimran0@gmail.com>
Wed, 25 Mar 2020 21:22:53 +0000 (02:52 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2020 07:37:38 +0000 (08:37 +0100)
Compress two lines into a single line if immediate return statement is found.
It also removes variable cmd_obj as it is no longer needed.

It is done using script Coccinelle.
And coccinelle uses following semantic patch for this compression function:

@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
Link: https://lore.kernel.org/r/20200325212253.GA8175@simran-Inspiron-5558
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_cmd.c

index 744b40d..42b0ea8 100644 (file)
@@ -362,11 +362,7 @@ exit:
 
 struct cmd_obj *rtw_dequeue_cmd(struct cmd_priv *pcmdpriv)
 {
-       struct cmd_obj *cmd_obj;
-
-       cmd_obj = _rtw_dequeue_cmd(&pcmdpriv->cmd_queue);
-
-       return cmd_obj;
+       return _rtw_dequeue_cmd(&pcmdpriv->cmd_queue);
 }
 
 void rtw_free_cmd_obj(struct cmd_obj *pcmd)