QAbstractSocket: Always set errorString right after socketError
authorKai Koehne <kai.koehne@theqtcompany.com>
Fri, 10 Jul 2015 13:03:43 +0000 (15:03 +0200)
committerKai Koehne <kai.koehne@theqtcompany.com>
Wed, 2 Sep 2015 07:05:55 +0000 (07:05 +0000)
Otherwise errorString() might not match error() in a
statusChanged handler.

Change-Id: If1250b4552412eabe88457dee031e4ef3f533838
Reviewed-by: Alex Trotsenko <alex1973tr@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
src/network/socket/qabstractsocket.cpp

index 009bc90bf5838805c8075fcb672c2d75be40357d..d1b13c1191d4665b003db2b719497cabb42a4462 100644 (file)
@@ -2086,10 +2086,10 @@ bool QAbstractSocket::waitForConnected(int msecs)
 
     if ((timedOut && state() != ConnectedState) || state() == ConnectingState) {
         d->socketError = SocketTimeoutError;
+        setErrorString(tr("Socket operation timed out"));
         d->state = UnconnectedState;
         emit stateChanged(d->state);
         d->resetSocketLayer();
-        setErrorString(tr("Socket operation timed out"));
     }
 
 #if defined (QABSTRACTSOCKET_DEBUG)