Handlification TODOs in scanner and string stream resolved.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/251263004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/scanner.cc b/src/scanner.cc
index d09dbb9..4ad0f41 100644 (file)
--- a/src/scanner.cc
+++ b/src/scanner.cc
@@ -1095,19 +1095,13 @@ bool Scanner::ScanRegExpFlags() {
 
 Handle<String> Scanner::AllocateNextLiteralString(Isolate* isolate,
                                                   PretenureFlag tenured) {
-  MaybeHandle<String> maybe_result;
   if (is_next_literal_one_byte()) {
-    maybe_result = isolate->factory()->NewStringFromOneByte(
-        next_literal_one_byte_string(), tenured);
+    return isolate->factory()->NewStringFromOneByte(
+        next_literal_one_byte_string(), tenured).ToHandleChecked();
   } else {
-    maybe_result = isolate->factory()->NewStringFromTwoByte(
-        next_literal_two_byte_string(), tenured);
+    return isolate->factory()->NewStringFromTwoByte(
+        next_literal_two_byte_string(), tenured).ToHandleChecked();
   }
-  // TODO(ishell): Temporarily returning null handle from here. I will proceed
-  // with maybehandlification in next CLs.
-  Handle<String> result;
-  if (!maybe_result.ToHandle(&result)) return Handle<String>();
-  return result;
 }
 
 

diff --git a/src/string-stream.cc b/src/string-stream.cc
index e9795ad..25e340b 100644 (file)
--- a/src/string-stream.cc
+++ b/src/string-stream.cc
@@ -265,14 +265,8 @@ void StringStream::OutputToFile(FILE* out) {
 
 
 Handle<String> StringStream::ToString(Isolate* isolate) {
-  MaybeHandle<String> maybe_result = isolate->factory()->NewStringFromUtf8(
-      Vector<const char>(buffer_, length_));
-
-  // TODO(ishell): Temporarily returning null handle from here. I will proceed
-  // with maybehandlification in next CLs.
-  Handle<String> result;
-  if (!maybe_result.ToHandle(&result)) return Handle<String>();
-  return result;
+  return isolate->factory()->NewStringFromUtf8(
+      Vector<const char>(buffer_, length_)).ToHandleChecked();
 }