caif_virtio: fix error return code in cfv_create_genpool()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 2 Apr 2013 06:15:56 +0000 (16:45 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Tue, 2 Apr 2013 06:18:25 +0000 (16:48 +1030)
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/net/caif/caif_virtio.c

index 316b184..0e3bede 100644 (file)
@@ -424,8 +424,10 @@ static int cfv_create_genpool(struct cfv_info *cfv)
        cfv->reserved_size = num_possible_cpus() * cfv->ndev->mtu;
        cfv->reserved_mem = gen_pool_alloc(cfv->genpool,
                                           cfv->reserved_size);
-       if (!cfv->reserved_mem)
+       if (!cfv->reserved_mem) {
+               err = -ENOMEM;
                goto err;
+       }
 
        cfv->watermark_tx = virtqueue_get_vring_size(cfv->vq_tx);
        return 0;