ALSA: timer: Use common error handling code in alsa_timer_init()

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/timer.c b/sound/core/timer.c
index 6051aed..6cdd04a 100644 (file)
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -2097,8 +2097,7 @@ static int __init alsa_timer_init(void)
        err = snd_timer_register_system();
        if (err < 0) {
                pr_err("ALSA: unable to register system timer (%i)\n", err);
-               put_device(&timer_dev);
-               return err;
+               goto put_timer;
        }
 
        err = snd_register_device(SNDRV_DEVICE_TYPE_TIMER, NULL, 0,
@@ -2106,12 +2105,15 @@ static int __init alsa_timer_init(void)
        if (err < 0) {
                pr_err("ALSA: unable to register timer device (%i)\n", err);
                snd_timer_free_all();
-               put_device(&timer_dev);
-               return err;
+               goto put_timer;
        }
 
        snd_timer_proc_init();
        return 0;
+
+put_timer:
+       put_device(&timer_dev);
+       return err;
 }
 
 static void __exit alsa_timer_exit(void)