mfd: lpc_ich: Assign subdevice ids automatically
authorMika Westerberg <mika.westerberg@linux.intel.com>
Tue, 9 Jun 2015 09:17:07 +0000 (12:17 +0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:30 +0000 (12:25 +0100)
Using -1 as platform device id means that the platform driver core will not
assign any id to the device (the device name will not have id at all). This
results problems on systems that have multiple PCHs (Platform Controller
HUBs) because all of them also include their own copy of LPC device.

All the subsequent device creations will fail because there already exists
platform device with the same name.

Fix this by passing PLATFORM_DEVID_AUTO as platform device id. This makes
the platform device core to allocate new ids automatically.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/lpc_ich.c

index 12d960a..8de3439 100644 (file)
@@ -934,8 +934,8 @@ gpe0_done:
        lpc_ich_enable_gpio_space(dev);
 
        lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_GPIO]);
-       ret = mfd_add_devices(&dev->dev, -1, &lpc_ich_cells[LPC_GPIO],
-                             1, NULL, 0, NULL);
+       ret = mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO,
+                             &lpc_ich_cells[LPC_GPIO], 1, NULL, 0, NULL);
 
 gpio_done:
        if (acpi_conflict)
@@ -1008,8 +1008,8 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)
        }
 
        lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_WDT]);
-       ret = mfd_add_devices(&dev->dev, -1, &lpc_ich_cells[LPC_WDT],
-                             1, NULL, 0, NULL);
+       ret = mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO,
+                             &lpc_ich_cells[LPC_WDT], 1, NULL, 0, NULL);
 
 wdt_done:
        return ret;