7l trocadero: reading right into enum variable may cause unwanted effects, use
authorKostya Shishkov <kostya.shishkov@gmail.com>
Tue, 1 Dec 2009 14:58:17 +0000 (14:58 +0000)
committerKostya Shishkov <kostya.shishkov@gmail.com>
Tue, 1 Dec 2009 14:58:17 +0000 (14:58 +0000)
intermediate buffer for reading value instead in RTMP protocol handler.

Originally committed as revision 20682 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavformat/rtmppkt.c

index 063a887..8f9d71d 100644 (file)
@@ -102,8 +102,9 @@ int ff_rtmp_packet_read(URLContext *h, RTMPPacket *p,
             if (url_read_complete(h, buf, 3) != 3)
                 return AVERROR(EIO);
             data_size = AV_RB24(buf);
-            if (url_read_complete(h, &type, 1) != 1)
+            if (url_read_complete(h, buf, 1) != 1)
                 return AVERROR(EIO);
+            type = buf[0];
             if (hdr == RTMP_PS_TWELVEBYTES) {
                 if (url_read_complete(h, buf, 4) != 4)
                     return AVERROR(EIO);