net: netcp: drop kfree for memory allocated with devm_kzalloc

It's not necessary to free memory allocated with devm_kzalloc in the
remove path and using kfree leads to a double free.

Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet
driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 11609d5..2fb5b6d 100644 (file)
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -2058,7 +2058,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device,
                if (module->release)
                        module->release(intf_modpriv->module_priv);
                list_del(&intf_modpriv->intf_list);
-               kfree(intf_modpriv);
        }
        WARN(!list_empty(&netcp->module_head), "%s interface module list is not empty!\n",
             ndev->name);
@@ -2153,7 +2152,6 @@ static int netcp_remove(struct platform_device *pdev)
                dev_dbg(&pdev->dev, "Removing module \"%s\"\n", module->name);
                module->remove(netcp_device, inst_modpriv->module_priv);
                list_del(&inst_modpriv->inst_list);
-               kfree(inst_modpriv);
        }
 
        /* now that all modules are removed, clean up the interfaces */