net: Remove redundant assignment to err
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 29 Apr 2021 01:32:36 +0000 (09:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Apr 2021 22:34:15 +0000 (15:34 -0700)
Variable 'err' is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence the 'If statements' and
assignments are redundantand and can be removed.

Cleans up the following clang-analyzer warning:

net/ipv6/seg6.c:126:4: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/seg6.c

index d2f8138..e412817 100644 (file)
@@ -122,9 +122,6 @@ static int seg6_genl_sethmac(struct sk_buff *skb, struct genl_info *info)
        hinfo = seg6_hmac_info_lookup(net, hmackeyid);
 
        if (!slen) {
-               if (!hinfo)
-                       err = -ENOENT;
-
                err = seg6_hmac_info_del(net, hmackeyid);
 
                goto out_unlock;