perf expr: Move the scanner_ctx into the parse_ctx

We currently maintain the two independently and copy from one to the
other. This is a burden when additional scanner context values are
necessary, so combine them.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Ahmad Yasin <ahmad.yasin@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Caleb Biggers <caleb.biggers@intel.com>
Cc: Florian Fischer <florian.fischer@muhq.space>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kshipra Bopardikar <kshipra.bopardikar@intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Miaoqian Lin <linmq006@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Perry Taylor <perry.taylor@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20220831174926.579643-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c
index 2efe9e3..7ca5e37 100644 (file)
--- a/tools/perf/tests/expr.c
+++ b/tools/perf/tests/expr.c
@@ -133,7 +133,7 @@ static int test__expr(struct test_suite *t __maybe_unused, int subtest __maybe_u
                                                    (void **)&val_ptr));
 
        expr__ctx_clear(ctx);
-       ctx->runtime = 3;
+       ctx->sctx.runtime = 3;
        TEST_ASSERT_VAL("find ids",
                        expr__find_ids("EVENT1\\,param\\=?@ + EVENT2\\,param\\=?@",
                                        NULL, ctx) == 0);

diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c
index c15a985..00bde68 100644 (file)
--- a/tools/perf/util/expr.c
+++ b/tools/perf/util/expr.c
@@ -310,7 +310,7 @@ struct expr_parse_ctx *expr__ctx_new(void)
                free(ctx);
                return NULL;
        }
-       ctx->runtime = 0;
+       ctx->sctx.runtime = 0;
 
        return ctx;
 }
@@ -344,16 +344,13 @@ static int
 __expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr,
              bool compute_ids)
 {
-       struct expr_scanner_ctx scanner_ctx = {
-               .runtime = ctx->runtime,
-       };
        YY_BUFFER_STATE buffer;
        void *scanner;
        int ret;
 
        pr_debug2("parsing metric: %s\n", expr);
 
-       ret = expr_lex_init_extra(&scanner_ctx, &scanner);
+       ret = expr_lex_init_extra(&ctx->sctx, &scanner);
        if (ret)
                return ret;
 

diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
index 0403a92..07af3d4 100644 (file)
--- a/tools/perf/util/expr.h
+++ b/tools/perf/util/expr.h
@@ -10,17 +10,17 @@
 
 struct metric_ref;
 
+struct expr_scanner_ctx {
+       int runtime;
+};
+
 struct expr_parse_ctx {
        struct hashmap  *ids;
-       int runtime;
+       struct expr_scanner_ctx sctx;
 };
 
 struct expr_id_data;
 
-struct expr_scanner_ctx {
-       int runtime;
-};
-
 struct hashmap *ids__new(void);
 void ids__free(struct hashmap *ids);
 int ids__insert(struct hashmap *ids, const char *id);

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 18aae04..b144c3e 100644 (file)
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -215,7 +215,7 @@ static struct metric *metric__new(const struct pmu_event *pe,
        }
        m->metric_expr = pe->metric_expr;
        m->metric_unit = pe->unit;
-       m->pctx->runtime = runtime;
+       m->pctx->sctx.runtime = runtime;
        m->has_constraint = metric_no_group || metricgroup__has_constraint(pe);
        m->metric_refs = NULL;
        m->evlist = NULL;
@@ -1626,7 +1626,7 @@ static int parse_groups(struct evlist *perf_evlist, const char *str,
                }
                expr->metric_unit = m->metric_unit;
                expr->metric_events = metric_events;
-               expr->runtime = m->pctx->runtime;
+               expr->runtime = m->pctx->sctx.runtime;
                list_add(&expr->nd, &me->head);
        }
 

diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 788ce5e..815af94 100644 (file)
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -911,7 +911,7 @@ static void generic_metric(struct perf_stat_config *config,
        if (!pctx)
                return;
 
-       pctx->runtime = runtime;
+       pctx->sctx.runtime = runtime;
        i = prepare_metric(metric_events, metric_refs, pctx, cpu_map_idx, st);
        if (i < 0) {
                expr__ctx_free(pctx);