amdgpu: Fix use-after-free bug in vamgr_deinit
authorTom St Denis <tom.stdenis@amd.com>
Fri, 9 Oct 2015 16:07:26 +0000 (12:07 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 22 Oct 2015 16:36:38 +0000 (12:36 -0400)
This patch fixes a use-after-free bug in the vamgr_deinit function.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
amdgpu/amdgpu_vamgr.c

index 2221da0..8a707cb 100644 (file)
@@ -57,8 +57,8 @@ drm_private void amdgpu_vamgr_init(struct amdgpu_bo_va_mgr *mgr, uint64_t start,
 
 drm_private void amdgpu_vamgr_deinit(struct amdgpu_bo_va_mgr *mgr)
 {
-       struct amdgpu_bo_va_hole *hole;
-       LIST_FOR_EACH_ENTRY(hole, &mgr->va_holes, list) {
+       struct amdgpu_bo_va_hole *hole, *tmp;
+       LIST_FOR_EACH_ENTRY_SAFE(hole, tmp, &mgr->va_holes, list) {
                list_del(&hole->list);
                free(hole);
        }