Update TODO, and also unref deviceeventcontroller when

registry is finalized.

git-svn-id: http://svn.gnome.org/svn/at-spi/trunk@451 e2bd861d-eb25-0410-b326-f6ed22b6b98c

diff --git a/ChangeLog b/ChangeLog
index 2941dd2ebffc615bc1934bd74ac07d2067d81985..b7e1f114ce11849f73845d798af5396a469d6ca4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2003-06-26  Bill Haneman <bill.haneman@sun.com>
+
+       * registryd/registry.c: 
+       (spi_registry_object_finalize): Unref the deviceeventcontroller.
+
+       * TODO: Update with 2.4/"Dev Complete" items.
+
 2003-06-26  Padraig O'Briain <padraig.obriain@sun.com>
 
        * atk-bridge/bridge.c:

diff --git a/TODO b/TODO
index 0ce5da5307c2542330788409412b91b1cac6db1e..7f36c822e872435aa5628855404ce5f5305ef27c 100644 (file)
--- a/TODO
+++ b/TODO
@@ -74,3 +74,48 @@ test:
        + update test-simple to do complete API tests
        + Expand tests for AtkTable
 
+=================
+
+for 2.4/'dev complete'
+
+[** denotes API extension!]
+
+** ATK API for text range bounds?
+
+** add ROLE_EDITBAR [describes objects, usually text entries, 
+                    that describe and/or control the operation of other
+                   components.  They both reflect stateful information 
+                   about the application or the currently-focussed 
+                   object within the app, and contain editable text.
+                   Examples include the URI/location entry field in
+                   browsers, the currently-active-file field in an editor,
+                    and the formula/edit field in a spreadsheet.]
+
+* multiple-workspace awareness
+
+* in deviceeventcontroller, better keysym/unicode mapping 
+       (i.e. more complete)
+
+* type checking in the 'event detail' methods
+        (see TODO comments in cspi/spi_event.c)
+
+* fix silly assumption(s) about apps DISPLAY being 
+        same as registry, and being the GDK_DISPLAY()
+       default.
+
+* remove listeners from the list if their processes die.
+
+* do better deregistration on registry finalize.
+
+* check what happens if XKB isn't available - make registry and bridges
+       at least not trash things (even if nonfunctional).
+
+* deviceeventcontroller.c: Distinguish between physical and logical
+       (i.e. button 1 versus "left mouse") mouse buttons.
+
+========
+
+2.6: 
+
+* use XIM for keysym/unicode mapping, string insertion.
+* toplevel windows: implement Z ordering via Component mdi_zorder API.

diff --git a/cspi/spi_event.c b/cspi/spi_event.c
index c12e3dcd106eb80da8a08ceb7c747e718be1ac7d..feb3e711a72b3455d61c599202b7ea5268755d5e 100644 (file)
--- a/cspi/spi_event.c
+++ b/cspi/spi_event.c
@@ -379,7 +379,7 @@ char *
 AccessibleTextChangedEvent_getChangeString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -396,7 +396,7 @@ char *
 AccessibleTextSelectionChangedEvent_getSelectionString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -414,7 +414,7 @@ char *
 AccessibleWindowEvent_getTitleString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -532,7 +532,7 @@ char *
 AccessibleTableCaptionChangedEvent_getCaptionString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -551,7 +551,7 @@ char *
 AccessibleTableRowDescriptionChangedEvent_getDescriptionString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -570,7 +570,7 @@ char *
 AccessibleTableColumnDescriptionChangedEvent_getDescriptionString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 
@@ -589,7 +589,7 @@ char *
 AccessibleDescriptionChangedEvent_getDescriptionString (const AccessibleEvent *e)
 {
   const InternalEvent *foo = (InternalEvent *) e;
-  /* TODO: check the event type? expensive... */
+  /* TODO: check the event type. */
   return cspi_internal_event_get_text (foo);
 }
 

diff --git a/registryd/deviceeventcontroller.c b/registryd/deviceeventcontroller.c
index 6edf938915346fe53956163a1cbb03c6206d94c8..aa2da0a4a0dc00581fe7feb5b3aa895166432cd5 100644 (file)
--- a/registryd/deviceeventcontroller.c
+++ b/registryd/deviceeventcontroller.c
@@ -339,7 +339,7 @@ spi_dec_button_update_and_emit (SpiDEController *controller,
 #endif
        snprintf (event_name, 22, "mouse:button:%d%c", button_number,
                  (is_down) ? 'p' : 'r');
-       /* TODO: distinguish between physical and 
+       /* TODO: FIXME distinguish between physical and 
         * logical buttons 
         */
        mouse_e.type      = (is_down) ? 
@@ -929,7 +929,7 @@ spi_device_event_controller_forward_mouse_event (SpiDEController *controller,
   snprintf (event_name, 22, "mouse:button:%d%c", button,
            (xevent->type == ButtonPress) ? 'p' : 'r');
 
-  /* TODO: distinguish between physical and logical buttons */
+  /* TODO: FIXME distinguish between physical and logical buttons */
   mouse_e.type      = (xevent->type == ButtonPress) ? 
                       Accessibility_BUTTON_PRESSED_EVENT :
                       Accessibility_BUTTON_RELEASED_EVENT;
@@ -2051,7 +2051,6 @@ impl_generate_keyboard_event (PortableServer_Servant           servant,
    * and fall back to XSendEvent() if XTest is not available.
    */
   
-  /* TODO: implement keystring mode also */
   gdk_error_trap_push ();
   key_synth_code = keycode;
 

diff --git a/registryd/registry.c b/registryd/registry.c
index 13f73c6ebe63534904b25161fbef840111872780..621c0d0d691a525d6fb88ebcb0e60dbc94182db7 100644 (file)
--- a/registryd/registry.c
+++ b/registryd/registry.c
@@ -157,8 +157,8 @@ static void
 spi_registry_object_finalize (GObject *object)
 {
   DBG (1, g_warning ("spi_registry_object_finalize called\n"));
+  g_object_unref (SPI_REGISTRY (object)->de_controller);
 
-  /* TODO: unref deviceeventcontroller, which disconnects key listener */
   G_OBJECT_CLASS (spi_registry_parent_class)->finalize (object);
 }
 
@@ -861,7 +861,7 @@ spi_registry_init (SpiRegistry *registry)
 {
   spi_registry_set_debug (g_getenv ("AT_SPI_DEBUG"));
   /*
-   * TODO: fixme, this module makes the foolish assumptions that
+   * TODO: FIXME, this module makes the foolish assumptions that
    * registryd uses the same display as the apps, and that the
    * DISPLAY environment variable is set.
    */