tty: nozomi: remove unneeded break
authorTom Rix <trix@redhat.com>
Mon, 19 Oct 2020 17:57:32 +0000 (10:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Oct 2020 12:44:43 +0000 (13:44 +0100)
A break is not needed if it is preceded by a return

Add explicit fallthrough

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20201019175732.3289-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/nozomi.c

index d42b854cb7df2b08227ebf4cba001615a8a2a0d3..861e9504319193b4f1dc25d02203e530ccd27ca7 100644 (file)
@@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start,
                buf16 = (u16 *) buf;
                *buf16 = __le16_to_cpu(readw(ptr));
                goto out;
-               break;
        case 4: /* 4 bytes */
                *(buf) = __le32_to_cpu(readl(ptr));
                goto out;
-               break;
        }
 
        while (i < size_bytes) {
@@ -460,15 +458,14 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,
                buf16 = (const u16 *)buf;
                writew(__cpu_to_le16(*buf16), ptr);
                return 2;
-               break;
        case 1: /*
                 * also needs to write 4 bytes in this case
                 * so falling through..
                 */
+               fallthrough;
        case 4: /* 4 bytes */
                writel(__cpu_to_le32(*buf), ptr);
                return 4;
-               break;
        }
 
        while (i < size_bytes) {