ibmvnic: substitute mb() with dma_wmb() for send_*crq* functions
authorLijun Pan <ljp@linux.ibm.com>
Sat, 13 Feb 2021 02:36:46 +0000 (20:36 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Feb 2021 23:11:04 +0000 (15:11 -0800)
The CRQ and subCRQ descriptors are DMA mapped, so dma_wmb(),
though weaker, is good enough to protect the data structures.

Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Acked-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index 7a5e589..927d5f3 100644 (file)
@@ -3599,7 +3599,7 @@ static int send_subcrq_indirect(struct ibmvnic_adapter *adapter,
        int rc;
 
        /* Make sure the hypervisor sees the complete request */
-       mb();
+       dma_wmb();
        rc = plpar_hcall_norets(H_SEND_SUB_CRQ_INDIRECT, ua,
                                cpu_to_be64(remote_handle),
                                ioba, num_entries);
@@ -3629,7 +3629,7 @@ static int ibmvnic_send_crq(struct ibmvnic_adapter *adapter,
        }
 
        /* Make sure the hypervisor sees the complete request */
-       mb();
+       dma_wmb();
 
        rc = plpar_hcall_norets(H_SEND_CRQ, ua,
                                cpu_to_be64(u64_crq[0]),