drm/hibmc: Remove error check from fbdev setup
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 08:26:33 +0000 (10:26 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 14:24:36 +0000 (16:24 +0200)
Generic fbdev support is a DRM client. Remove the error check as the
driver's probe function should not depend on a DRM client's state.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-3-tzimmermann@suse.de
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

index 79a180a..a6fd0c2 100644 (file)
@@ -307,11 +307,7 @@ static int hibmc_load(struct drm_device *dev)
        /* reset all the states of crtc/plane/encoder/connector */
        drm_mode_config_reset(dev);
 
-       ret = drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth);
-       if (ret) {
-               DRM_ERROR("failed to initialize fbdev: %d\n", ret);
-               goto err;
-       }
+       drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth);
 
        return 0;