drm/i915/gt: Expose timeslice duration to sysfs

Execlists uses a scheduling quantum (a timeslice) to alternate execution
between ready-to-run contexts of equal priority. This ensures that all
users (though only if they of equal importance) have the opportunity to
run and prevents livelocks where contexts may have implicit ordering due
to userspace semaphores.

The timeslicing mechanism can be compiled out with

	./scripts/config --set-val DRM_I915_TIMESLICE_DURATION 0

The timeslice duration can be adjusted per-engine using,

	/sys/class/drm/card?/engine/*/timeslice_duration_ms

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Steve Carbonari <steven.carbonari@intel.com>
Tested-by: Steve Carbonari <steven.carbonari@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200228131716.3243616-3-chris@chris-wilson.co.uk

diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
index c280b6ae38ebe9dc6659c257ced8c2cef9bab644..d8d4a16179bd6a01c7c4714b105a9efe8a13ba9b 100644 (file)
--- a/drivers/gpu/drm/i915/Kconfig.profile
+++ b/drivers/gpu/drm/i915/Kconfig.profile
@@ -73,4 +73,7 @@ config DRM_I915_TIMESLICE_DURATION
          is scheduled for execution for the timeslice duration, before
          switching to the next context.
 
+         This is adjustable via
+         /sys/class/drm/card?/engine/*/timeslice_duration_ms
+
          May be 0 to disable timeslicing.

diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
index 81b5c90df5fc4eeb7a84825f8264d090290e57d5..53402edbf98a5eb110b0909f8ac5908d8fe508bb 100644 (file)
--- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
+++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
@@ -142,6 +142,48 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 static struct kobj_attribute all_caps_attr =
 __ATTR(known_capabilities, 0444, all_caps_show, NULL);
 
+static ssize_t
+timeslice_store(struct kobject *kobj, struct kobj_attribute *attr,
+               const char *buf, size_t count)
+{
+       struct intel_engine_cs *engine = kobj_to_engine(kobj);
+       unsigned long long duration;
+       int err;
+
+       /*
+        * Execlists uses a scheduling quantum (a timeslice) to alternate
+        * execution between ready-to-run contexts of equal priority. This
+        * ensures that all users (though only if they of equal importance)
+        * have the opportunity to run and prevents livelocks where contexts
+        * may have implicit ordering due to userspace semaphores.
+        */
+
+       err = kstrtoull(buf, 0, &duration);
+       if (err)
+               return err;
+
+       if (duration > jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT))
+               return -EINVAL;
+
+       WRITE_ONCE(engine->props.timeslice_duration_ms, duration);
+
+       if (execlists_active(&engine->execlists))
+               set_timer_ms(&engine->execlists.timer, duration);
+
+       return count;
+}
+
+static ssize_t
+timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
+{
+       struct intel_engine_cs *engine = kobj_to_engine(kobj);
+
+       return sprintf(buf, "%lu\n", engine->props.timeslice_duration_ms);
+}
+
+static struct kobj_attribute timeslice_duration_attr =
+__ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
+
 static void kobj_engine_release(struct kobject *kobj)
 {
        kfree(kobj);
@@ -203,6 +245,10 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
                if (sysfs_create_files(kobj, files))
                        goto err_object;
 
+               if (intel_engine_has_timeslices(engine) &&
+                   sysfs_create_file(kobj, &timeslice_duration_attr.attr))
+                       goto err_engine;
+
                if (0) {
 err_object:
                        kobject_put(kobj);