zink: Fix waiting for texture commit semaphores.
authorTatsuyuki Ishi <ishitatsuyuki@gmail.com>
Tue, 14 Nov 2023 07:30:24 +0000 (16:30 +0900)
committerEric Engestrom <eric@engestrom.ch>
Sat, 18 Nov 2023 21:15:16 +0000 (21:15 +0000)
The commit was always being treated as failed...

Fixes: d1456a6b0ad ("zink: add semaphore handling for sparse binds")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26171>
(cherry picked from commit 94e867e4a682305e28efbacafc01551172f5a11a)

.pick_status.json
src/gallium/drivers/zink/zink_bo.c

index 74002f0..2f736f2 100644 (file)
         "description": "zink: Fix waiting for texture commit semaphores.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "d1456a6b0ad0dee9936caa52c9fd915c4bfaa61b",
         "notes": null
index 0194974..ddd4288 100644 (file)
@@ -1128,8 +1128,8 @@ zink_bo_commit(struct zink_screen *screen, struct zink_resource *res, unsigned l
                fprintf(stderr, "zink: leaking sparse backing memory\n");
             }
          }
+         ok = false;
       }
-      ok = false;
    }
 out: