IB/srp: Fix CONFIG_DYNAMIC_DEBUG=n build
authorBart Van Assche <bart.vanassche@sandisk.com>
Mon, 21 Nov 2016 21:56:46 +0000 (13:56 -0800)
committerDoug Ledford <dledford@redhat.com>
Wed, 14 Dec 2016 18:31:37 +0000 (13:31 -0500)
Avoid that the kernel build fails as follows if dynamic debug support
is disabled:

drivers/infiniband/ulp/srp/ib_srp.c:2272:3: error: implicit declaration of function 'DEFINE_DYNAMIC_DEBUG_METADATA'
drivers/infiniband/ulp/srp/ib_srp.c:2272:33: error: 'ddm' undeclared (first use in this function)
drivers/infiniband/ulp/srp/ib_srp.c:2275:39: error: '_DPRINTK_FLAGS_PRINT' undeclared (first use in this function)

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/ulp/srp/ib_srp.c

index d980fb4..8bb720c 100644 (file)
@@ -64,6 +64,11 @@ MODULE_LICENSE("Dual BSD/GPL");
 MODULE_VERSION(DRV_VERSION);
 MODULE_INFO(release_date, DRV_RELDATE);
 
+#if !defined(CONFIG_DYNAMIC_DEBUG)
+#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)
+#define DYNAMIC_DEBUG_BRANCH(descriptor) false
+#endif
+
 static unsigned int srp_sg_tablesize;
 static unsigned int cmd_sg_entries;
 static unsigned int indirect_sg_entries;
@@ -1556,7 +1561,6 @@ static int srp_map_idb(struct srp_rdma_ch *ch, struct srp_request *req,
        return 0;
 }
 
-#if defined(DYNAMIC_DATA_DEBUG)
 static void srp_check_mapping(struct srp_map_state *state,
                              struct srp_rdma_ch *ch, struct srp_request *req,
                              struct scatterlist *scat, int count)
@@ -1580,7 +1584,6 @@ static void srp_check_mapping(struct srp_map_state *state,
                       scsi_bufflen(req->scmnd), desc_len, mr_len,
                       state->ndesc, state->nmdesc);
 }
-#endif
 
 /**
  * srp_map_data() - map SCSI data buffer onto an SRP request
@@ -1669,14 +1672,12 @@ static int srp_map_data(struct scsi_cmnd *scmnd, struct srp_rdma_ch *ch,
        if (ret < 0)
                goto unmap;
 
-#if defined(DYNAMIC_DEBUG)
        {
                DEFINE_DYNAMIC_DEBUG_METADATA(ddm,
                        "Memory mapping consistency check");
-               if (unlikely(ddm.flags & _DPRINTK_FLAGS_PRINT))
+               if (DYNAMIC_DEBUG_BRANCH(ddm))
                        srp_check_mapping(&state, ch, req, scat, count);
        }
-#endif
 
        /* We've mapped the request, now pull as much of the indirect
         * descriptor table as we can into the command buffer. If this