pinctrl: bcm: ns: Remove redundant dev_err call
authorShang XiaoJing <shangxiaojing@huawei.com>
Fri, 23 Sep 2022 10:10:38 +0000 (18:10 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 4 Oct 2022 07:24:04 +0000 (09:24 +0200)
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Link: https://lore.kernel.org/r/20220923101038.18036-1-shangxiaojing@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-ns.c

index 65a8654..465cc96 100644 (file)
@@ -233,10 +233,8 @@ static int ns_pinctrl_probe(struct platform_device *pdev)
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                                           "cru_gpio_control");
        ns_pinctrl->base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(ns_pinctrl->base)) {
-               dev_err(dev, "Failed to map pinctrl regs\n");
+       if (IS_ERR(ns_pinctrl->base))
                return PTR_ERR(ns_pinctrl->base);
-       }
 
        memcpy(pctldesc, &ns_pinctrl_desc, sizeof(*pctldesc));