perf symbols: Use the right variable to check for kallsyms in the cache
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 22 Jan 2010 16:35:02 +0000 (14:35 -0200)
committerIngo Molnar <mingo@elte.hu>
Wed, 27 Jan 2010 11:46:49 +0000 (12:46 +0100)
Probably this wasn't noticed when testing this on my parisc
machine because I must have copied manually to its cache the
vmlinux file used in the x86_64 machine, now that I tried
looking on a x86-32 machine with a fresh cache, kernel symbols
weren't being resolved even with the right kallsyms copy on its
cache, duh.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1264178102-4203-2-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/util/symbol.c

index 1270cf8..f1f609d 100644 (file)
@@ -1650,12 +1650,12 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map,
                             getenv("HOME"), sbuild_id) == -1)
                        return -1;
 
+               kallsyms_filename = kallsyms_allocated_filename;
+
                if (access(kallsyms_filename, F_OK)) {
                        free(kallsyms_allocated_filename);
                        return -1;
                }
-
-               kallsyms_filename = kallsyms_allocated_filename;
        } else {
                /*
                 * Last resort, if we don't have a build-id and couldn't find