fs/namei.c: kill follow_mount()
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 27 Feb 2020 01:09:37 +0000 (20:09 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 2 Apr 2020 05:09:23 +0000 (01:09 -0400)
The only remaining caller (path_pts()) should be using follow_down()
anyway.  And clean path_pts() a bit.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c

index 669a0df..1f092f9 100644 (file)
@@ -1414,22 +1414,6 @@ static inline int handle_mounts(struct nameidata *nd, struct dentry *dentry,
 }
 
 /*
- * Skip to top of mountpoint pile in refwalk mode for follow_dotdot()
- */
-static void follow_mount(struct path *path)
-{
-       while (d_mountpoint(path->dentry)) {
-               struct vfsmount *mounted = lookup_mnt(path);
-               if (!mounted)
-                       break;
-               dput(path->dentry);
-               mntput(path->mnt);
-               path->mnt = mounted;
-               path->dentry = dget(mounted->mnt_root);
-       }
-}
-
-/*
  * This looks up the name in dcache and possibly revalidates the found dentry.
  * NULL is returned if the dentry does not exist in the cache.
  */
@@ -2640,7 +2624,7 @@ int path_pts(struct path *path)
         */
        struct dentry *parent = dget_parent(path->dentry);
        struct dentry *child;
-       struct qstr this;
+       struct qstr this = QSTR_INIT("pts", 3);
 
        if (unlikely(!path_connected(path->mnt, parent))) {
                dput(parent);
@@ -2648,15 +2632,13 @@ int path_pts(struct path *path)
        }
        dput(path->dentry);
        path->dentry = parent;
-       this.name = "pts";
-       this.len = 3;
        child = d_hash_and_lookup(parent, &this);
        if (!child)
                return -ENOENT;
 
        path->dentry = child;
        dput(parent);
-       follow_mount(path);
+       follow_down(path);
        return 0;
 }
 #endif