fs: nfs: sysfs: use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Mon, 5 Dec 2022 09:19:16 +0000 (17:19 +0800)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 6 Dec 2022 17:32:37 +0000 (12:32 -0500)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/sysfs.c

index a6f7403..26f8ece 100644 (file)
@@ -82,7 +82,7 @@ static ssize_t nfs_netns_identifier_show(struct kobject *kobj,
        ssize_t ret;
 
        rcu_read_lock();
-       ret = scnprintf(buf, PAGE_SIZE, "%s\n", rcu_dereference(c->identifier));
+       ret = sysfs_emit(buf, "%s\n", rcu_dereference(c->identifier));
        rcu_read_unlock();
        return ret;
 }