tty: serial: meson: The system stuck when you run the stty command on the console...
authorYu Tu <yu.tu@amlogic.com>
Fri, 25 Feb 2022 07:39:21 +0000 (15:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 26 Feb 2022 09:03:21 +0000 (10:03 +0100)
Start the console and run the following commands in turn:
stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. The
system will stuck.

Signed-off-by: Yu Tu <yu.tu@amlogic.com>
Link: https://lore.kernel.org/r/20220225073922.3947-6-yu.tu@amlogic.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/meson_uart.c

index ba8dc20..d19349e 100644 (file)
@@ -365,8 +365,13 @@ static void meson_uart_set_termios(struct uart_port *port,
        writel(val, port->membase + AML_UART_CONTROL);
 
        baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
+
+       spin_unlock_irqrestore(&port->lock, flags);
+
        meson_uart_change_speed(port, baud);
 
+       spin_lock_irqsave(&port->lock, flags);
+
        port->read_status_mask = AML_UART_TX_FIFO_WERR;
        if (iflags & INPCK)
                port->read_status_mask |= AML_UART_PARITY_ERR |