thermal/drivers/mediatek/lvts: Fix parameter check in lvts_debugfs_init()
authorMinjie Du <duminjie@vivo.com>
Thu, 13 Jul 2023 04:24:12 +0000 (12:24 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 16 Aug 2023 07:54:32 +0000 (09:54 +0200)
The documentation says "If an error occurs, ERR_PTR(-ERROR) will be
returned" but the current code checks against a NULL pointer returned.

Fix this by checking if IS_ERR().

Signed-off-by: Minjie Du <duminjie@vivo.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230713042413.2519-1-duminjie@vivo.com
drivers/thermal/mediatek/lvts_thermal.c

index 61c3de4..bc726ac 100644 (file)
@@ -201,7 +201,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td)
        int i;
 
        lvts_td->dom_dentry = debugfs_create_dir(dev_name(dev), NULL);
-       if (!lvts_td->dom_dentry)
+       if (IS_ERR(lvts_td->dom_dentry))
                return 0;
 
        for (i = 0; i < lvts_td->num_lvts_ctrl; i++) {