usb: gadget: u_ether: Don't warn in gether_setup_name_default()
authorJon Hunter <jonathanh@nvidia.com>
Thu, 9 Feb 2023 12:53:19 +0000 (12:53 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Feb 2023 11:36:22 +0000 (12:36 +0100)
The function gether_setup_name_default() is called by various USB
ethernet gadget drivers. Calling this function will select a random
host and device MAC addresses. A properly working driver should be
silent and not warn the user about default MAC addresses selection.
Given that the MAC addresses are also printed when the function
gether_register_netdev() is called, remove these unnecessary warnings.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Link: https://lore.kernel.org/r/20230209125319.18589-2-jonathanh@nvidia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/u_ether.c

index c8862a7..f259975 100644 (file)
@@ -812,13 +812,11 @@ struct net_device *gether_setup_name_default(const char *netname)
        snprintf(net->name, sizeof(net->name), "%s%%d", netname);
 
        eth_random_addr(dev->dev_mac);
-       pr_warn("using random %s ethernet address\n", "self");
 
        /* by default we always have a random MAC address */
        net->addr_assign_type = NET_ADDR_RANDOM;
 
        eth_random_addr(dev->host_mac);
-       pr_warn("using random %s ethernet address\n", "host");
 
        net->netdev_ops = &eth_netdev_ops;