firmware: tegra: Remove surplus dev_err() when using platform_get_irq_byname()

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

./drivers/firmware/tegra/bpmp-tegra210.c:204:2-9: line 204 is redundant
because platform_get_irq() already prints an error
./drivers/firmware/tegra/bpmp-tegra210.c:216:2-9: line 216 is redundant
because platform_get_irq() already prints an error

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2579
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c
index 6421e11..6295f56 100644 (file)
--- a/drivers/firmware/tegra/bpmp-tegra210.c
+++ b/drivers/firmware/tegra/bpmp-tegra210.c
@@ -200,10 +200,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
        }
 
        err = platform_get_irq_byname(pdev, "tx");
-       if (err < 0) {
-               dev_err(&pdev->dev, "failed to get TX IRQ: %d\n", err);
+       if (err < 0)
                return err;
-       }
 
        priv->tx_irq_data = irq_get_irq_data(err);
        if (!priv->tx_irq_data) {
@@ -212,10 +210,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
        }
 
        err = platform_get_irq_byname(pdev, "rx");
-       if (err < 0) {
-               dev_err(&pdev->dev, "failed to get rx IRQ: %d\n", err);
+       if (err < 0)
                return err;
-       }
 
        err = devm_request_irq(&pdev->dev, err, rx_irq,
                               IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp);