fix sonar issue: checkstyle:MagicNumberCheck

diff --git a/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTest.java b/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTest.java
index 67e363f..5b62fe5 100644 (file)
--- a/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTest.java
+++ b/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTest.java
@@ -40,7 +40,7 @@ public class ReportTest {
     public void testGetSetId() throws Exception {
         assertNotNull(report.getId());
         Long old = report.getId();
-        Long newid = 123l;
+        final Long newid = 123l;
         report.setId(newid);
 
         assertNotEquals(old, report.getId());

diff --git a/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTypeTest.java b/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTypeTest.java
index d142993..d33eede 100644 (file)
--- a/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTypeTest.java
+++ b/servers/commons/src/test/java/com/samsung/commons/domain/device/statistics/ReportTypeTest.java
@@ -30,7 +30,7 @@ public class ReportTypeTest {
     public void testGetSetId() throws Exception {
         assertNotNull(reportType.getId());
         Long old = reportType.getId();
-        Long newid = 123l;
+        final Long newid = 123l;
         reportType.setId(newid);
 
         assertNotEquals(old, reportType.getId());

diff --git a/servers/dsm/src/main/java/com/samsung/dsm/controller/DashboardDevicesController.java b/servers/dsm/src/main/java/com/samsung/dsm/controller/DashboardDevicesController.java
index 8825169..647ee19 100644 (file)
--- a/servers/dsm/src/main/java/com/samsung/dsm/controller/DashboardDevicesController.java
+++ b/servers/dsm/src/main/java/com/samsung/dsm/controller/DashboardDevicesController.java
@@ -135,7 +135,7 @@ public class DashboardDevicesController {
     @RequestMapping(value = "/reports/{id}", method = RequestMethod.GET)
     public String iotDeviceReports(Model model, @PathVariable Long id) {
         // FIXME: returns only 10 last reports for each report type
-        int limit = 10;
+        final int limit = 10;
         ViewDevice viewDevice;
         Device device = deviceService.findById(id);
 

diff --git a/servers/dsm/src/main/java/com/samsung/dsm/rest/report/ReportApi.java b/servers/dsm/src/main/java/com/samsung/dsm/rest/report/ReportApi.java
index c1165a4..b12fbe2 100644 (file)
--- a/servers/dsm/src/main/java/com/samsung/dsm/rest/report/ReportApi.java
+++ b/servers/dsm/src/main/java/com/samsung/dsm/rest/report/ReportApi.java
@@ -80,7 +80,7 @@ public class ReportApi {
     @ResponseBody
     public String findReportsByDeviceUuid(@PathVariable String deviceUuId) {
         Device device = deviceService.findByUUID(deviceUuId);
-        int limit = 10;
+        final int limit = 10;
 
         Map<String, List<Map<String, String>>> mapReports = new HashMap<>();
         if (device != null) {

diff --git a/servers/mq/src/test/java/com/samsung/servermq/utils/CborTest.java b/servers/mq/src/test/java/com/samsung/servermq/utils/CborTest.java
index 63edb8a..6a552d0 100644 (file)
--- a/servers/mq/src/test/java/com/samsung/servermq/utils/CborTest.java
+++ b/servers/mq/src/test/java/com/samsung/servermq/utils/CborTest.java
@@ -36,7 +36,7 @@ public class CborTest {
     @Test
     public void testEncodeAndDecodePayloadFromCborWrongPayload() {
         Cbor<String> cbor = new Cbor<>();
-        Long data = 121213131l;
+        final Long data = 121213131l;
         byte[] payload = cbor.encodingPayloadToCbor(data);
         String result = (String) cbor.parsePayloadFromCbor(payload, String.class);
         assertNotNull(result);