pinctrl: bcm: bcm6362: fix warning
authorÁlvaro Fernández Rojas <noltari@gmail.com>
Tue, 30 Mar 2021 10:32:25 +0000 (12:32 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 31 Mar 2021 12:33:48 +0000 (14:33 +0200)
The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix
the warning.

Fixes: 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Link: https://lore.kernel.org/r/20210330103225.3949-1-noltari@gmail.com
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm6362.c

index eb7ec80..40ef495 100644 (file)
@@ -496,11 +496,11 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
 static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
 {
        const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+       unsigned int basemode = (uintptr_t)desc->drv_data;
        unsigned int mask = bcm63xx_bank_pin(pin);
 
-       if (desc->drv_data)
-               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-                                  (uint32_t) desc->drv_data, 0);
+       if (basemode)
+               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode, 0);
 
        if (pin < BCM63XX_BANK_GPIOS) {
                /* base mode 0 => gpio 1 => mux function */