usb: musb: core: drop redundant checks

In musb_{save|restore}_context() the expression '&musb->endpoints[i]' just
cannot be NULL, so the checks have no sense at all -- after dropping them,
the local variables 'hw_ep' are no longer necessary, so drop them as well.

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/3f8f60d9-f1b5-6b2c-1222-39b156151a22@omp.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index f7b1d59..bbbcfd4 100644 (file)
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2684,13 +2684,7 @@ static void musb_save_context(struct musb *musb)
        musb->context.devctl = musb_readb(musb_base, MUSB_DEVCTL);
 
        for (i = 0; i < musb->config->num_eps; ++i) {
-               struct musb_hw_ep       *hw_ep;
-
-               hw_ep = &musb->endpoints[i];
-               if (!hw_ep)
-                       continue;
-
-               epio = hw_ep->regs;
+               epio = musb->endpoints[i].regs;
                if (!epio)
                        continue;
 
@@ -2765,13 +2759,7 @@ static void musb_restore_context(struct musb *musb)
                musb_writeb(musb_base, MUSB_DEVCTL, musb->context.devctl);
 
        for (i = 0; i < musb->config->num_eps; ++i) {
-               struct musb_hw_ep       *hw_ep;
-
-               hw_ep = &musb->endpoints[i];
-               if (!hw_ep)
-                       continue;
-
-               epio = hw_ep->regs;
+               epio = musb->endpoints[i].regs;
                if (!epio)
                        continue;